backstage-plugins icon indicating copy to clipboard operation
backstage-plugins copied to clipboard

docs(Quay): Update quay plugin README.md

Open yangcao77 opened this issue 1 year ago • 3 comments

the proxy config is wrong, added endpoints to fix it.

the wrong doc brought a lot confusion. the issue has been identified in https://redhat-internal.slack.com/archives/C05HGAR2DT5/p1714587620348839

yangcao77 avatar May 02 '24 16:05 yangcao77

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 02 '24 16:05 sonarqubecloud[bot]

@yangcao77 Thanks for the PR, can you update the commit and title to docs(Quay): Update quay plugin README.md to make semantic job happier

/cc @karthikjeeyar

invincibleJai avatar May 06 '24 09:05 invincibleJai

/lgtm /approve

karthikjeeyar avatar Jun 07 '24 05:06 karthikjeeyar

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karthikjeeyar Once this PR has been reviewed and has the lgtm label, please assign nickboldt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 07 '24 05:06 openshift-ci[bot]

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Jun 07 '24 15:06 openshift-ci[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 07 '24 15:06 sonarqubecloud[bot]

/retest

karthikjeeyar avatar Jun 11 '24 04:06 karthikjeeyar

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Jul 27 '24 22:07 openshift-merge-robot

Closing this PR in favor of https://github.com/janus-idp/backstage-plugins/pull/2032

karthikjeeyar avatar Aug 09 '24 08:08 karthikjeeyar