feat(bulk-import): Rhidp 1769 add repo row actions
Resolves: RHDIP-1769: Add row actions to the Added repositories table
Note: This PR is based off #1541 . Will rebase to main branch after the dependency PR gets merged.
Screen recording:
https://github.com/janus-idp/backstage-plugins/assets/26255262/5c0ee7ee-2d52-43ae-bba5-6ad1d461ffbd
Updates(5/1):
@ciiay l have some adjustments for the tooltips we show and for the modal:
-
When we show the external link icon, the tooltip text should be "View catalog-info.yaml file"
-
Let's have only "Remove" for this trash icon
-
For the last icon let's use just "Refresh"
About the modal, the content seems not aligned (Figma), and the text should be "Removing a repository erases all associated information from the Catalog page."
Quality Gate passed
Issues
4 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code
Hey @ciiay , do you mind taking a look on these two small issues?
-
It seems the tooltip is still "Delete Repository" instead of "Remove"
-
The alignment of the modal seems a bit off and not like in the design: Screenshot from the video:
The design (Figma):
Hi @ShiranHi , did you take these screenshots from the screen recording video? I didn't update the screen recording, only uploaded some updated screenshots which show the changes I made to address your previous comments about tooltip message and alert model alignment. So the screen recording didn't reflect the code change.
I just uploaded a new screen recording. Let me know if it looks good or not now.
I just uploaded a new screen recording. Let me know if it looks good or not now.
Yes, I took it from the screen recording, thank you for updating it. It seems that the tooltip text is correct, but the text "Removing a repository..." is not aligned, could you please take a look on that?
Hi @ShiranHi , thanks for the pointer. I over looked the text alignment in my previous fix. Uploaded a new screen recording and a screenshot to reflect the fix.
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code
@ciiay Changes made to the preview file in the org view no longer persist after saving.
Verified the changes /lgtm
Thank you @ciiay !
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: debsmita1
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [debsmita1]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment