backstage-plugins icon indicating copy to clipboard operation
backstage-plugins copied to clipboard

feat(bulk-import): Rhidp 1769 add repo row actions

Open ciiay opened this issue 1 year ago • 4 comments

Resolves: RHDIP-1769: Add row actions to the Added repositories table

Note: This PR is based off #1541 . Will rebase to main branch after the dependency PR gets merged.

Screen recording:

https://github.com/janus-idp/backstage-plugins/assets/26255262/5c0ee7ee-2d52-43ae-bba5-6ad1d461ffbd

Updates(5/1): rhidp_1769_update_51_1 rhidp_1769_update_51_2 rhidp_1769_update_51_3 rhidp_1769_update_51_4

ciiay avatar Apr 26 '24 21:04 ciiay

@ciiay l have some adjustments for the tooltips we show and for the modal:

  1. When we show the external link icon, the tooltip text should be "View catalog-info.yaml file" image01

  2. Let's have only "Remove" for this trash icon image02

  3. For the last icon let's use just "Refresh" image03

About the modal, the content seems not aligned (Figma), and the text should be "Removing a repository erases all associated information from the Catalog page." image04

ShiranHi avatar Apr 30 '24 09:04 ShiranHi

Hey @ciiay , do you mind taking a look on these two small issues?

  1. It seems the tooltip is still "Delete Repository" instead of "Remove" image01

  2. The alignment of the modal seems a bit off and not like in the design: Screenshot from the video: image02

The design (Figma): image03

ShiranHi avatar Jun 04 '24 10:06 ShiranHi

Hi @ShiranHi , did you take these screenshots from the screen recording video? I didn't update the screen recording, only uploaded some updated screenshots which show the changes I made to address your previous comments about tooltip message and alert model alignment. So the screen recording didn't reflect the code change.

I just uploaded a new screen recording. Let me know if it looks good or not now.

ciiay avatar Jun 04 '24 12:06 ciiay

I just uploaded a new screen recording. Let me know if it looks good or not now.

Yes, I took it from the screen recording, thank you for updating it. It seems that the tooltip text is correct, but the text "Removing a repository..." is not aligned, could you please take a look on that?

ShiranHi avatar Jun 04 '24 12:06 ShiranHi

Hi @ShiranHi , thanks for the pointer. I over looked the text alignment in my previous fix. Uploaded a new screen recording and a screenshot to reflect the fix.

ciiay avatar Jun 04 '24 14:06 ciiay

@ciiay Changes made to the preview file in the org view no longer persist after saving.

debsmita1 avatar Jun 25 '24 11:06 debsmita1

Verified the changes /lgtm

Thank you @ciiay !

debsmita1 avatar Jun 26 '24 16:06 debsmita1

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 26 '24 16:06 openshift-ci[bot]