python-wifi-survey-heatmap icon indicating copy to clipboard operation
python-wifi-survey-heatmap copied to clipboard

Fixes sudo, UI, duplicate point plotting issues

Open byteit101 opened this issue 6 months ago • 2 comments

IMPORTANT: Please take note of the below checklist, especially the first two items.

Pull Request Checklist

  • [x] All pull requests must include the Contributor License Agreement (see below).
  • [ ] Code should conform to the following:
    • [x] pep8 compliant with some exceptions (see pytest.ini)
    • [ ] 100% test coverage with pytest (with valid tests). If you have difficulty writing tests for the code, feel free to ask for help or submit the PR without tests.
    • [ ] Complete, correctly-formatted documentation for all classes, functions and methods.
    • [ ] documentation has been rebuilt with tox -e docs
    • [ ] All modules should have (and use) module-level loggers.
    • [ ] Commit messages should be meaningful, and reference the Issue number if you're working on a GitHub issue (i.e. "issue #x - "). Please refrain from using the "fixes #x" notation unless you are sure that the the issue is fixed in that commit.
    • [ ] Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in wifi-survey-heatmap, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it) is being made under the same license as the wifi-survey-heatmap project (the Affero GPL v3, or any subsequent version of that license if adopted by wifi-survey-heatmap).
  • My contribution may perpetually be included in and distributed with wifi-survey-heatmap; submitting this pull request grants a perpetual, global, unlimited license for it to be used and distributed under the terms of wifi-survey-heatmap's license.
  • I have the legal power and rights to agree to these terms.

UI & Sudo & Duplicate Point fixes

I think the UI repainting is fully fixed here. I'm not confident of sudo/paplay yet.

UI + Scan background thread

The scan method now launches a background thread, if not already launched, to do the work of scanning. This makes the UI interactive and keeps desktop environments happy. I had to setup a pubsub thread callback mechanism as the scan background thread wants to repaint and update the status.

Sudo + paplay ding

This works, in some environments. I need to fix the other environments and/or document. Feedback appreciated. The UI drops permissions ASAP once it launches the scan subprocess. Communication is via JSON and a Scanner proxy object. Also a security win.

Plotting duplicate points

Duplicate points cause fun patterns, but useless output. Now they are filtered out

byteit101 avatar Aug 12 '24 02:08 byteit101