opentuner icon indicating copy to clipboard operation
opentuner copied to clipboard

halidetuner substitutes *_HOOK unsafely

Open jrk opened this issue 10 years ago • 0 comments

The match used generally winds up eating all whitespace preceding the macro, often including the newline at the end of a preceding comment line, leading to code like:

// disabled code;

AUTOTUNE_HOOK(f)

becoming:

// disabled code;schedule.definition.inlined.here;

This has bitten me several times in different contexts. It should probably use a less aggressive regexp that doesn't eat surrounding whitespace.

jrk avatar Feb 27 '14 00:02 jrk