ionic-epubjs icon indicating copy to clipboard operation
ionic-epubjs copied to clipboard

Update for epubjs v0.3+

Open askilondz opened this issue 6 years ago • 5 comments

Should update the example to be compatible with the latest version as there are breaking changes: https://github.com/futurepress/epub.js/wiki/Updating-to-v0.3-from-v0.2

askilondz avatar May 30 '18 19:05 askilondz

Oh wow, I thought Epubjs was pretty much dead. Nice that it isn't!

I don't have the time to work on this though right now. Anyone feel free to fork the repo, do the necessary upgrades and then send a PR for the changes - I will gladly accept it or link to your repository.

janpio avatar Jun 01 '18 09:06 janpio

Just made a pull request. I got most of this working on my own project yesterday so was quickly able to port over a lot of the changes.

askilondz avatar Jun 01 '18 15:06 askilondz

@askilondz Hey aski thanks for making a lot of the changes already. Do you have any idea why there is an error when clicking on a chapter in the toc list? For example when opening the metamorphosis book and clicking on chapter 3 the following error appears. Also happens with a lot of other epub files. The weird thing is that is still navigates to the selected chapter.

knipsel

rubieruben avatar Jul 03 '18 14:07 rubieruben

@rubieruben hmm that is weird though I would suspect maybe it's something with using compressed vs uncompressed (unzipped) epubs. In my project I'm actually using uncompressed epubs and have not had this error.

askilondz avatar Jul 03 '18 14:07 askilondz

@askilondz For me it doesn't matter if the epubs are compressed or unpacked, I still get the error. It seems that when running on a device the error isn't really an issue so I will leave it for now. Just with ionic serve it is a bit annoying.

rubieruben avatar Jul 04 '18 11:07 rubieruben