Janosh Riebesell

Results 165 issues of Janosh Riebesell

See the ToC in [Pandas docs](https://pandas.pydata.org/pandas-docs/version/1.4/whatsnew/v1.4.0.html#multithreaded-csv-reading-with-a-new-csv-engine-based-on-pyarrow) for what this behavior looks like.

enhancement

This code ```py benchmark_path = "tmp-benchmark.json" mbbm = MatbenchBenchmark.from_file(benchmark_path) ``` raises ```py ValueError: Cannot validate task matbench_jdft2d unless all folds recorded!; folds [0, 2, 3, 4] not recorded! ``` if...

Seems like there's something wrong with `score_array()` in the classification case. https://github.com/materialsproject/matbench/blob/c3b910e4f06b79eea1a8a6c7b67ea5a605948306/matbench/data_ops.py#L83-L123 `accuracy` comes before `rocauc` in `CLF_METRICS`: ```py CLF_METRICS = ["accuracy", "balanced_accuracy", "f1", "rocauc"] ``` That means this code...

code
high priority

Closes #63. Change `AlmostOp()` to rewrite `self.assertAlmostEqual(3, 3.0)` to `3 == approx(3.0)` instead of `round(abs(3 - 3.0), 7) == 0`. Still needs tests. Also currently requires adding `from pytest import...

The replacement for `self.assertAlmostEqual(3, 3.0)` is `round(abs(3 - 3.0), 7) == 0`. How about replacing it with `pytest.approx(3) == 3.0` instead? [[pytest docs](https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest-approx)]

### Describe the bug [`svelte-multiselect`](https://github.com/janosh/svelte-multiselect) stopped working in the REPL in v5.0.0. The previous v4.0.6 release is working fine. The error message v5 raises is: Unexpected token (Note that you...

Still learning TypeScript so this may be a dumb question. `setupTypeScript.js` installs `tslib`: https://github.com/sveltejs/template/blob/f92a0a4dfda3a4eff6474ca242c8aea4be9260d1/scripts/setupTypeScript.js#L29 [Reading the docs](https://www.typescriptlang.org/tsconfig#downlevelIteration), > If the importHelpers flag is on, these helper functions are instead imported...

addresses https://github.com/materialsproject/foundation/pull/24

testing
ecosystem
ci

2nd attempt, 1st one in #783 aborted but [significant speedup confirmed](https://github.com/materialsproject/atomate2/pull/783#issuecomment-2016395045)

dependencies
ci

Just mentioning this here in case you were looking for an edge case to include in your testing or something like that. The website doesn't parse this very long CIF...

bug