Janosh Riebesell

Results 651 comments of Janosh Riebesell

@empet You misunderstood. I _do_ want the population data in the tooltip, just not for points where that data is missing. The line ```py df["pop"] = None ``` is just...

I know. They're all `None` because I was too lazy to only set the value for that point to `None` which is being hovered in the screenshot.

The error disappears in 3.6.0 by following the error message and passing `cax=ax.inset_axes([0.95, 0.1, 0.05, 0.8])`.

Good to know I can keep auto-layout for the color bar. > If it is ambiguous what axes to use, pass in the axes directly: What changed between 3.5.1 and...

`pre-commit` hooks can be both linters and formatters. Formatters should fix violations themselves, linters only flag them. Any hook can also be a combination of both, i.e. fix some violations...

Here's the plot output from `test_proj_plot()` for later reference/discussion. Is the text extending beyond the legend boundary easy to fix? ![test_proj_plot-1](https://user-images.githubusercontent.com/30958850/195407100-7a1c74d9-7ad4-4a3b-9541-fa0c6d073c06.png) ![test_proj_plot-2](https://user-images.githubusercontent.com/30958850/195407107-81011b2d-ee2c-4267-bc37-47cfe07f2d92.png) ![test_proj_plot-3](https://user-images.githubusercontent.com/30958850/195407111-fb06d1a8-5afa-488a-94c2-5db5a46a1d4a.png) ![test_proj_plot-4](https://user-images.githubusercontent.com/30958850/195407113-79b02dfe-8139-4aad-9d52-4f8e70970e50.png) ![test_proj_plot-5](https://user-images.githubusercontent.com/30958850/195407116-f198c5db-9f63-4243-ab3f-28103b744858.png) ![test_proj_plot-6](https://user-images.githubusercontent.com/30958850/195407118-f1a85de9-8da0-4dc7-9963-fdf919168c98.png) ![test_proj_plot-7](https://user-images.githubusercontent.com/30958850/195407120-f23961f8-ecb4-4373-b9a3-4274f12e5d79.png)

I think you force-pushed over the commit 709cda1 I added after 702b5bd to fix `mypy` errors. Would be better if you could `git pull` remote changes to your branch first...

@JiQi535 In case you rename the function, I think it can also be simplified from this: ```py def expected_radius(struct): element_list = struct.composition.chemical_system.split("-") element_list = [get_el_sp(e) for e in element_list] ele1,...

Btw, this function fails for unary structures. > ValueError: not enough values to unpack (expected at least 2, got 1)