harviewer icon indicating copy to clipboard operation
harviewer copied to clipboard

Load via PINF JS Loader & minor changes

Open cadorn opened this issue 9 years ago • 8 comments

I ported the harviewer to run on my JS loader and only needed to make a few minor changes to get things working.

Everything should still work as before using requirejs but now also works via PINF.

I am using this to auto-bundle the viewer to embed it in other tooling. I'll be tweaking it to complete it as a standalone component, add bundle generation via PINF to the build process and document things more.

This will not run yet as I have to publish some PINF upstream dependencies but once that is done anyone will be able to install the nodejs dev server and work on the viewer using the requirejs or pinf loaders.

I am submitting this now for initial review and will send more patches to complete it.

  • Are you open to me maintaining this on your repo?
  • Are the changes I had to make acceptable?
  • Are you open to other backwards compatible changes that I may have to make?
  • Are you open to upgrading to RequireJS 2.x (using 0.x now)?
  • Are you open to changes that will make the harviewer a nice embeddable component?
  • Any other comments that will affect a merge?

I am looking forward to discussing this more. With this, we are one step closer to scraping JS modules from the Firebug source and use it in other tooling as I am now doing with this port. I'll show you how I have embedded the har viewer and am using some domplate reps from it in my new fireconsole project.

cadorn avatar Jan 06 '15 05:01 cadorn

By the way. Awesome job on structuring and coding this project. It was done very future-proof. It required only minimal changes.

cadorn avatar Jan 06 '15 05:01 cadorn

Got bundle generation working as part of build and publishing to github pages.

Check it out: http://fireconsole.github.io/harviewer/

Still some fixes but its working :)

So anyone can now clone the harviewer, make changes, publish to gihub pages and other people can embed the component that was published in their tooling conflict free by pulling it directly from github pages. Will publish more info on embedding as part of component.

cadorn avatar Jan 07 '15 05:01 cadorn

http://fireconsole.github.io/harviewer/ now loads an optimized widget.

One bug left for Firefox (works on Google Chrome) and will then work on widget embedding example.

cadorn avatar Jan 12 '15 03:01 cadorn

All done.

See: http://fireconsole.github.io/harviewer/

The Embed tag shows how to embed in own app with JSFiddle example.

I'll be working on an API for the widget so it can be integrated into tooling without the full UI.

I am looking to integrate this into fireconsole as a renderer. You will be able to fire a HAR URI at fireconsole and it will load a mapped viewer to display it. This will work for all data objects.

cadorn avatar Jan 13 '15 04:01 cadorn

All dependencies should be published.

You should be able to clone this now on your own branch and run ant publish-to-github to publish to your own github pages: https://janodvarko.github.io/harviewer/

So any contributor can now preview changes in issues by publishing their branch to github pages.

cadorn avatar Jan 16 '15 03:01 cadorn

Working on using the component within fireconsole now.

cadorn avatar Jan 16 '15 03:01 cadorn

FYI: the fireconsole widget is now deployed as part of the devcomp.io instances and I have updated firebug.io:

http://fireconsole-widget-console.firebug.io/

As I push changes to this stack now (like dynamically loading the harviewer) I will keep firebug.io updated until I eventually circle back to loading fireconsole as a devtools/firebug extension where the source loads from online or the local system sources.

At that point we can take a serious look at the composition of firebug and see if we can not make much of it portable in this fashion and thus available for embedding in third party tools.

cadorn avatar Jan 19 '15 06:01 cadorn

I hope to, later this year, fix this patch to get the bundling working again.

cadorn avatar Aug 11 '16 17:08 cadorn