indicatetls icon indicating copy to clipboard operation
indicatetls copied to clipboard

Dark theme with system dark theme

Open ArchangeGabriel opened this issue 4 years ago • 4 comments

In Firefox they are three default themes: light, dark, system.

If set to system and using a dark system theme, the icon still uses light theme icons. It should uses the dark theme ones. ;)

ArchangeGabriel avatar May 03 '20 15:05 ArchangeGabriel

Hint: This system-dark works with the quite new CSS media query feature called prefers-color-scheme. It allows you to detect whether the system/user wants a dark website, so you can adjust your CSS.

rugk avatar May 03 '20 19:05 rugk

Firefox reverts (user preference) to light theme if privacy.resistFingerprinting is set to true - see here. This is something to keep in mind, took me some time to figure out why Firefox was not respecting OS theme.

ashucg avatar May 08 '20 17:05 ashucg

But you can use @rugk https://github.com/rugk/website-dark-mode-switcher to force it anyway. Works is most cases, though not all.

ArchangeGabriel avatar May 08 '20 17:05 ArchangeGabriel

@ArchangeGabriel I have used that addon in past (when I had set privacy.resistFingerprinting to true now I am using an addon for it) but it only works for websites, not Firefox interface/addons. So if you have enabled privacy.resistFingerprinting any addon that uses prefers-color-scheme to provide light and dark theme support will only use light color scheme. You can follow the steps I have mentioned in my bug report to reproduce the behavior. And since it is intentional, I don't think Mozilla is going to change it unless they have a very strong reason to do so and I also believe that Mozilla is going to prefer privacy over other things, so maybe never.

ashucg avatar May 08 '20 18:05 ashucg