vue-notion icon indicating copy to clipboard operation
vue-notion copied to clipboard

Add Vue 3 Support? πŸ‘€

Open janniks opened this issue 4 years ago β€’ 7 comments
trafficstars

Hi vue-notion users!

I am thinking about adding support for Vue 3. However, due to tooling and API differences this will be quite complicated. It will likely have to live in its own repo or branch. Also Vue 3 will not be usable with Nuxt, until Nuxt 3 is released.

As soon as Nuxt 3 is released, I will definitely migrate this repo to Vue 3.

Think of this issue as a poll:

  • ~Vote β™₯️ : Add Vue 3 support as its own version (e.g. [email protected])~
  • ~Vote πŸ‘€ : Wait until Nuxt is compatible with Vue 3~

EDIT: As Vue 3 is now the next hot+stable thing, I'll introduce the Vue 3 compatible version as >= 3.0.0 (skipping 2.0.0) β€” hopefully soon.... Nuxt 3 isn't quite out yet, but I'll try to make it work πŸ€·β€β™€

janniks avatar Jul 21 '21 09:07 janniks

@janniks just wondering what the status on this is. With Nuxt3 coming out as well as Vue3 with Vite, what do you think about making this a composable for vue3 so it could also be used regardless of vue3 framework?

CalebKester avatar Jan 26 '22 14:01 CalebKester

bitmoji

yacosta738 avatar Feb 10 '22 02:02 yacosta738

What's the status of it?

paulocastellano avatar Jul 27 '22 18:07 paulocastellano

I want use notion with Nuxt 3. Please share if you have information that help.

rashidpathiyil avatar Aug 01 '22 13:08 rashidpathiyil

Looks like Vue 3 is the new standard at this point, so I'll prioritize a switch soon. Will give a status update in two weeks (on vacation currently).

janniks avatar Aug 04 '22 16:08 janniks

@janniks any update πŸ‘€

barisener avatar Aug 22 '22 14:08 barisener

Opened a PR: https://github.com/janniks/vue-notion/pull/102 (still some way to go, especially on the Nuxt front)

Feel free to test the alpha released under 3.0.0-alpha.0 (e.g. npm i [email protected])

janniks avatar Aug 25 '22 22:08 janniks

Sorry, for the delays β€” 3.0.0-alpha.1 now available, maybe this should work soon πŸš€

janniks avatar Dec 22 '22 16:12 janniks

Trying to use it on Nuxt 3.

When installed it warns about vue-dompurify-html requiring Vue 2:

> npm install vue-notion@^3.0.0-alpha.1 --save-dev
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/vue
npm WARN   vue@"^3.2.13" from @hsorby/[email protected]
npm WARN   node_modules/@hsorby/vue3-katex
npm WARN     @hsorby/vue3-katex@"^0.6.0-rc.4" from [email protected]
npm WARN     node_modules/vue-notion
npm WARN   9 more (@nuxt/vite-builder, @unhead/vue, @vitejs/plugin-vue, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer vue@"^2.0.0" from [email protected]
npm WARN node_modules/vue-dompurify-html
npm WARN   vue-dompurify-html@"^2.5.2" from @hsorby/[email protected]
npm WARN   node_modules/@hsorby/vue3-katex
npm WARN 
npm WARN Conflicting peer dependency: [email protected]

Then after start:

 ERROR  Cannot start nuxt:  Cannot read properties of undefined (reading 'options')

  at module.exports (node_modules/vue-notion/nuxt/index.js:9:13)
  at installModule (node_modules/@nuxt/kit/dist/index.mjs:416:9)
  at async initNuxt (node_modules/nuxt/dist/index.mjs:1825:7)
  at async load (node_modules/nuxi/dist/chunks/dev.mjs:6779:9)
  at async Object.invoke (node_modules/nuxi/dist/chunks/dev.mjs:6840:5)0:54:57
  at async _main (node_modules/nuxi/dist/cli.mjs:50:20)

Also using component directly (without Nuxt module) does not work: Snímek obrazovky 2022-12-31 v 17 32 33

iBobik avatar Dec 31 '22 19:12 iBobik

✨ Vue 3 support in vue-notion is here!

I believe [email protected] is working, so I pushed it to main and released. Still marking as beta for now until the first folks try it out. πŸ™Œ

janniks avatar Mar 26 '23 21:03 janniks

That is amazing ! :D Thank you so much

ebanDev avatar Nov 28 '23 16:11 ebanDev