Jan Niehusmann

Results 281 comments of Jan Niehusmann

This was applied as part of #860

I see two issues with your code: - You busy loop within the interrupt. That doesn't look useful. Either busy loop (then you don't need an interrupt), or quickly do...

Sorry, I don't have a complete example available, and don't know the DMA interrupts well enough to quickly write one. As a rough sketch, I'd try something like this (pseudocode):...

> We might want to block this until we've written a new interrupt macro that works like the cortex-m-rt macro and does the static mut transform and type-checks the function...

> But given 2040 has the same problem the question is whether we want to fix it here or make a plan and fix it later. That's an option, I...

But to be honest, there's a second thing I dislike about the interrupt macro, so I'm biased. For me, it's totally non-obvious that the macro annotation changes the code inside...

> So I guess the risk is that both CPUs enter the same interrupt handler at the same time. If one peripheral interrupt signal is unmasked on both CPUs, that...

For the rp2040, we could use separate vector tables for core0 and core1, and let the macro create two distinct functions with their own statics, so even if an interrupt...

It was obviously naive to expect that `cargo clippy --fix` creates properly formatted code.

Looking at the UART code as it seems to be more performance critical. If I take the whole function (and not only the div_ceil), the two variants compare different. In...