Jan Aagaard Meier comments

Results 88 comments of


                                            Jan Aagaard Meier

[MSSQL]DataTypes.STRING should be Varchar or NVarchar ?

https://github.com/sequelize/sequelize/blob/16b39c612c721612e65323bb875bd07a5a6e3811/lib/dialects/mssql/data-types.js#L48

A feature similar to ActiveRecord's find_each

Generators are a cool posibility, I don't even know they were possible to do in js. Both I don't think they are the right solution here, since I guess that...

instance.destroy(...) does not return any information if rows has been deleted or not

@alekbarszczewski We could, but that would break backwards compat - and only be usefully for postgres, but an annoyance for everyone else - having to use `spread` instead of `then`...

instance.destroy(...) does not return any information if rows has been deleted or not

@alekbarszczewski It's not perfect, but I think that would be the best solution for now. I'm also thinking we might want to deprecate always returning the instance from update and...

instance.destroy(...) does not return any information if rows has been deleted or not

Yeah I don't think returning affected rows is a good idea - but if we return null when rows == 0 for update that would explicitly show the error -...

instance.destroy(...) does not return any information if rows has been deleted or not

Then I think we can safely change destroy to return null / instance depending on whether it was deleted or not :)

WHERE Query on JSON datatype

As you've noticed, JSON is currently only supported in postgres https://github.com/sequelize/sequelize/issues/4727

Completely raw query yes, or you could use literal: ``` js User.findAll({ where: { $and: [ sequelize.where( sequelize.literal('facebook->"$.id"'), "1239871587612" ) ] } }); ``` (this example shows how the condition...