image_processing
image_processing copied to clipboard
janko
Support mini_magick 5.0.0
the gemspec currently restricts mini_magick to (>= 4.9.5, < 5), which prevents the update to the newly released 5.0.0 .
Yes, I plan on doing that 👍🏻 That version constraint was intentional, as there will be changes needed to support MiniMagick 5.
What specific functionality are you eager to get from MiniMagick 5.0? I'm not in a rush because that release was mostly about removing deprecated stuff.
No rush, just a policy that we should avoid any library we use to fall two major releases behind, and as some are quite slow I got in the habit to keep up upon things. But taking this is on your roadmap, I'm fine waiting...
@Hessah95 you may have misunderstood this. This is only an issue discussing the possibility to even start an update to mini_magick v5. There is currently no code supporting this, you are free to open a PR to add support for this upgrade.
Alpine linux has updated imagemagick to >v7 which fully deprecates functionality used by mini_magick <5. In order to support our production docker images which run on alpine, we'd like to upgrade mini_magick to 5.X but cannot due to image_processing version restrictions. I'm not saying that this should drive prioritization of this issue, but I wanted to provide some context that will be shared with anyone using alpine docker images for deploying ruby apps.
Are you referring only to the convert => magick deprecation? That shouldn't issue deprecation warnings on MiniMagick < 5, MiniMagick should be silencing those.
But yeah, that's additional reason for me to get moving with the MiniMagick 5.x support 👍🏻
I have a PR here https://github.com/janko/image_processing/pull/132 that begins this work. Happy to get feedback.
https://github.com/janko/image_processing/pull/132 has been merged and released in 1.14.0, so closing this one.