jan iversen

icon location granada, spain icon location Enjoying living in Granada/Spain, while helping on FOSS projects. Made my first program in 1977 and never stopped.

Results 123 comments of jan iversen

Function code 43 fails because of incomplete receival of bytes

Still on the list to be corrected.

Automate examples.

@dhoomakethu one for you, which should be a lot easier for you than for me.

unit parameter

Just had a quick view of your commit, looks good, suppose you are going to submit a PR at some point in time ?

unit parameter

bandit is only needed for development not for runtime.

unit parameter

I mean it is only needed for Pymodbus development, not if you develop an application.

Parameter documentation do not correspond to actual parameters.

@dhoomakethu The documentation is still not fixed, so why close it ?

Unit ID not handled properly in async clients

Solved on dev.

Correct way to keep connection open?

Tested ModbusTcpClient and ModbusAsyncTcpClient with a server (no real device) and had it do a couple of requests, sleep for 10 hours and then repeat. So far it have been...

updated time.sleep to 0.02s in _wait_for_data() under sync.py

Of course we can, but you need to have patience. Why do you think that 0,02 is universally true, when 0,01 is not? This is in a loop is you...

updated time.sleep to 0.02s in _wait_for_data() under sync.py

I thought the 0,01 was to allow other threads to run. If you use timeout in the call it will loop automatically. I am looking at replacing these short sleeps...