Tomasz Janiszewski

Probably the easiest option will be to create some tests for it. Here are some hints where memory is allocated: 1. `HardMaxCacheSize` - limits memory used by `BytesQueue` 2. `Shards`...

Got following message from @dependabot > ## ⚠️ Dependabot wasn't able to update downloading > The module path downloading found in your go.mod doesn't match the actual path `github.com/google/gnostic` found...

Hi @tsaridas It's good idea to make [`MARATHON_CONSUL_LABEL`](https://github.com/allegro/marathon-consul/blob/master/apps/app.go#L9) configurable and add possibility to register all services (e.g. provided config value is empty). Changes are required in [AppId.ConsulServiceName](https://godoc.org/github.com/allegro/marathon-consul/apps#AppId.ConsulServiceName) and [Config](https://godoc.org/github.com/allegro/marathon-consul/config#Config). This...

@tsaridas I think your problem is not related to `MARATHON_CONSUL_LABEL`. In my opinion it should stay as is. We could add another configuration option to say all services should be...

App definition for given version is immutable so we can cache it. This will reduce Marathon queries but will increase memory usage (one app definition JSON takes approx 2.36K). We...

I agree but this should encourage us to double check if specific method/field really need to be public

I made a small comparison between viper and flag. We try to minimize dependencies we are using in the code. Viper looks nice but we don't need most of it's...

Thanks for response. Indeed I forgot about some features of cobra/viper that we might want. I'm not familiar with this tools so I'm not a fan of it. From my...

Anny update on this? Does anybody want to prepare PR with better configs handling?

Maybe it's an issue with bintray API (see: https://github.com/allegro/marathon-consul/issues/188 https://github.com/allegro/marathon-consul/issues/90) I not sure if the release script trigger works correctly cc @pbetkier @ojagodzinski