rcon-client icon indicating copy to clipboard operation
rcon-client copied to clipboard

Published 20 hours ago • verified publisher icon janispritzkau

[PR] fixed resolve on end

Open axi92 opened this issue 4 years ago • 2 comments

If had the issue that the rcon.end() does not resolve.

Please look over my PR and maybe merge the fix. I tried it on Ark Survival Evolved. Can somebody try this fix on Minecraft maybe too?

axi92 avatar Jun 13 '20 23:06 axi92

This makes no sense. The socket is responsible for emitting the close event, the code should not be emitting it at all. If the event isn't received that means the socket hasn't fully closed yet and you need to find out why that is the case, it might be that Ark Survival Evolved is improperly closing the TCP connection.

Hornwitser avatar Jun 15 '20 15:06 Hornwitser

Hmm it looks like that. The end event is never called without those changes that I made. I can connect, auth, execute the command but end() is never resolved...

@Hornwitser do you have Discord so maybe I can provide you an Ark server to test this on? That is my code I am using: https://github.com/axi92/sunny-cron/blob/master/app/index.js

axi92 avatar Jun 16 '20 07:06 axi92