Michał Janiszewski

Results 224 comments of Michał Janiszewski

Perhaps worth noting: on Windows we produce static builds, so we can simply provide just one binary with all the things baked in.

Does snap automatically figure out the cmake's build type?

Note: I am not a Windows user. vcpkg (https://github.com/Microsoft/vcpkg) is a package manager that greatly eases the pain of building software on Windows, especially with MSVC. It can readily support...

Having ported a bunch of stuff to emscripten/webassembly and then some more to UWP, based on _my_ experience with autotools and cmake, I say the latter is vastly easier to...

I saw some being introduced in https://github.com/fuzzylite/fuzzylite/commit/03bf16264094f3934b1c392eb7b51450ecfeadb2 and I can still see `FL_BUILD_TESTS` being part of CMake: https://github.com/fuzzylite/fuzzylite/blob/570b466/fuzzylite/CMakeLists.txt#L230, which I found confusing as to why the tests are gone. I...

`release` seems to be using updated setup on travis involving docker, while `develop` looks to operate directly on bare system. Do you have plans to unify that?

My objection regarding improper commit message still stands

``` modification for compatibility for smartversion compile (including android), some compatibility patch are from previous pull request ``` is not something I would ever want to see as a commit....

There are still errors when compiling with `-fstrict-aliasing` on 35c2d67bcf7a649d: ``` miniz.c: In function ‘tdefl_find_match’: miniz.c:1348:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] mz_uint16 c01 = TDEFL_READ_UNALIGNED_WORD(&d->m_dict[pos +...