jan icon indicating copy to clipboard operation
jan copied to clipboard

feat: replace Tauri dialog plugin with rfd integration

Open qnixsynapse opened this issue 1 month ago • 2 comments

Describe Your Changes

Remove tauri-plugin-dialog dependency and its capability entry, adding our custom rfd (with xdg-desktop-portal dialog support on Linux) as a cross‑platform native file dialog library. Introduce open_dialog and save_dialog commands that expose file‑selection and save dialogs to the frontend, along with a DialogOpenOptions model for filter, directory, and multiple‑file support. Update the TauriDialogService to invoke these new commands instead of the removed plugin, ensuring a cleaner build and consistent dialog behaviour across desktop targets.

Fixes Issues

  • Closes #6722
  • Closes #

Self Checklist

  • [ ] Added relevant comments, esp in complex areas
  • [ ] Updated docs (for bug fixes / features)
  • [ ] Created issues for follow-up changes or refactoring needed

qnixsynapse avatar Nov 03 '25 02:11 qnixsynapse

Barecheck - Code coverage report

Total: 29.93%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web-app/vite.config.web.ts1-5, 8-12, 15, 17-18, 20-21, 33, 39-42, 44-59, 61-85, 87, 89-106, 108-109
web-app/src/services/dialog/tauri.ts5, 7, 9-31, 33-41

github-actions[bot] avatar Nov 03 '25 02:11 github-actions[bot]

@urmauur Can push the image attachment file chooser to tauri rfd fix here.

qnixsynapse avatar Nov 04 '25 05:11 qnixsynapse

@urmauur Can push the image attachment file chooser to tauri rfd fix here.

hey @qnixsynapse it's already on dev, u can pull latest dev

urmauur avatar Nov 05 '25 02:11 urmauur

Already rebased and tested yesterday. Screencast_20251104_212314.webm

qnixsynapse avatar Nov 05 '25 02:11 qnixsynapse

Tested on MacOS:

  • Add images, doc
  • Import GGUF

Vanalite avatar Nov 05 '25 08:11 Vanalite