jan icon indicating copy to clipboard operation
jan copied to clipboard

idea: Add 'In Use' as sorting filter option

Open robertgro opened this issue 8 months ago • 4 comments

Problem Statement

Hi, if I'm in the model Hub, I'm missing the option to sort the models by those already downloaded: https://github.com/menloresearch/jan/blob/86b2a64c70db576f25904af87e56743ee9c6641b/web/screens/Hub/index.tsx#L161

Feature Idea

Add a sorting menu filter option to https://github.com/menloresearch/jan/blob/86b2a64c70db576f25904af87e56743ee9c6641b/web/screens/Hub/index.tsx#L58

which reads 'In Use' or something similar with the proper functionality.

Due to I'm lacking the time to dig deeper into your codebase and creating a PR myself, I guess you are good to go by either utilizing an already defined webhook https://github.com/menloresearch/jan/blob/86b2a64c70db576f25904af87e56743ee9c6641b/web/hooks/useModels.ts#L34

or maybe by straight using the AtomValue https://github.com/menloresearch/jan/blob/86b2a64c70db576f25904af87e56743ee9c6641b/web/containers/ModelDownloadButton/index.tsx#L35

Or another way https://github.com/search?q=repo%3Amenloresearch%2Fjan+downloaded&type=code&p=2

Shouldn't be that challenging for a fullstack newcomer. 😅

Thank you & best regards!

robertgro avatar May 01 '25 09:05 robertgro

Hi @robertgro it sounds like you mention My Models page?

louis-jan avatar May 16 '25 17:05 louis-jan

No. How do you come up with that @louis-menlo ?

robertgro avatar May 16 '25 17:05 robertgro

@robertgro, yeah downloaded models can be found there. We are currently reworking on a new Hub UI on release/v0.5.18, might add a new filtering option there.

louis-jan avatar May 16 '25 18:05 louis-jan

@robertgro, yeah downloaded models can be found there. We are currently reworking on a new Hub UI on release/v0.5.18, might add a new filtering option there.

Thank you for taking this into consideration. A first proposal is been found in the OP. Would appreciate the hub update. @louis-menlo

robertgro avatar May 16 '25 19:05 robertgro

Apologize for not making this clear at the beginning.

The new UI changes are exactly what I was looking for with this ticket.

Image

Thank you @louis-menlo, keep going, I appreciate your work!

(closing this because this is done).

robertgro avatar Jul 11 '25 17:07 robertgro