jan icon indicating copy to clipboard operation
jan copied to clipboard

epic: format generated code in code format (not plain text)

Open xx88xx opened this issue 1 year ago • 8 comments

Motivation

Seems all the other LLMs do this now, so would be very useful comfort to have in Jan!

xx88xx avatar May 16 '24 06:05 xx88xx

hi @xx88xx, sorry, is this what you mean? image The copy button will help copy code in the same format that is being displayed 🙏

Van-QA avatar May 16 '24 08:05 Van-QA

I also sometimes run into this issue. Does anyone know if different models maybe use different syntax for things like code blocks? Like how we have multiple different prompt templates/tokens?

mr-september avatar May 20 '24 06:05 mr-september

Hi @Van-QA ! Thanks for the response. Since posting this, noticed it works in the more popular models. I agree with @mr-september sometimes it works as in the picture you attached, but often especially on some of the more bespoke models it shows up unformatted. @mr-september might be onto something with the different syntax.

xx88xx avatar May 20 '24 13:05 xx88xx

thank you, can you let us know more details of the failed model / step to reproduce? @xx88xx

Van-QA avatar May 22 '24 02:05 Van-QA

With some further testing/hindsight, I think I only experienced this when using Llama3/fine-tunes released in the first week or so, where there were issues with the tokens or something, e.g.

  1. https://github.com/ggerganov/llama.cpp/issues/6770
  2. https://www.reddit.com/r/LocalLLaMA/comments/1cltac3/part3_cause_to_issue_found_possible_bug_llama3/

Recently I haven't ran into it again. So it's likely some kind of syntax/formatting-specific thing, as previously suspected. No idea if this was also the case for @xx88xx?

mr-september avatar Jun 05 '24 05:06 mr-september

Can I work on this issue

Realmbird avatar Jun 08 '24 02:06 Realmbird

Can I work on this issue

YES PLEASE :"> @Realmbird

ux-han avatar Jul 02 '24 18:07 ux-han

Assigned @Van-QA to follow up when needed.

ux-han avatar Jul 02 '24 18:07 ux-han

Hey @Realmbird how is it going so far

ux-han avatar Aug 28 '24 11:08 ux-han

Works for me on v0.5.3+ closing image

freelerobot avatar Sep 05 '24 07:09 freelerobot