jan icon indicating copy to clipboard operation
jan copied to clipboard

feat: support for deeplinks into the app

Open julien-c opened this issue 1 year ago • 1 comments

Hi! Is there a way for the Jan app to open deeplinks (like jan://) from e.g. the id for a model repo hosted on huggingface?

Would that be interesting to implement?

julien-c avatar May 07 '24 18:05 julien-c

@imtuyethan for future consideration https://github.com/janhq/jan/issues/2590 https://github.com/janhq/jan/issues/2878

Van-QA avatar May 08 '24 02:05 Van-QA

  1. Thank @namchuai for resolving the issue with Windows: clicking the deep link only opens the Jan app, without loading the HF modal. ✅
  2. Unfortunately, the issue is still happening on Linux :x:
  3. On the other hand, with the Jan app that already loaded deep link, updating it to a higher version will show this error toast msg :x: image

Van-QA avatar May 13 '24 03:05 Van-QA

No 1 and No 2 are resolved as of Jan v0.4.12-416 🙏

Van-QA avatar May 13 '24 06:05 Van-QA

All issues were resolved as of Jan v0.4.12-417 🙏. cc @janhq/pena for documentation Sample URL: jan://models/huggingface/TheBloke/Magicoder-S-DS-6.7B-GGUF

Van-QA avatar May 13 '24 10:05 Van-QA

@Van-QA Hi van, I just want to confirm regarding the deeplink. The template for deeplink is: jan://models/huggingface/(This is where the user can customize what model they want to import). Is this correct?

irfanpena avatar May 14 '24 03:05 irfanpena

@Van-QA Hi van, I just want to confirm regarding the deeplink. The template for deeplink is: jan://models/huggingface/(This is where the user can customize what model they want to import). Is this correct?

@irfanpena, yes, and they will use the HF model id which can be collected from HF website e.g. jan://models/huggingface/janhq/trinity-v1-GGUF Note that HF models that have restrictions will not supported as of now (pending on https://github.com/janhq/jan/issues/2756)

https://huggingface.co/janhq/trinity-v1-GGUF image

In the future, Hugging Face will help us create the link in their site, users only have to click on that to import to Jan app :pray:

Van-QA avatar May 14 '24 03:05 Van-QA

this is so awesome! can't wait to open Jan.app directly from HF model page 🥰

julien-c avatar May 14 '24 09:05 julien-c