bug: doesn't gracefully stop a model
Describe the bug Most of the time, it does not gracefully stop a model. Causing UI in a limbo state.
hi @kundeng , please share with us:
- Your OS version
- Your spec: CPU serial, memory
- Jan app version
- your app.log
Noticed the same while using the context length slider. Each numerical change during a single slide triggers a nitro kill. This spam can lead to a limbo state where nitro is not stopped and time-out messages flood the logs.
The workaround: kill nitro.exe from the task manager.
Win 11 pro x64, 32GB RAM, AMD Ryzen 7 7700X, AMD RX6800XT 16GB, Jan 0.4.9-343
2024-03-26T12:35:14.765Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.776Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.786Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.793Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.800Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.807Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.814Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.821Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.827Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.835Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.841Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.849Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:14.855Z [NITRO]::Debug: Request to kill Nitro
2024-03-26T12:35:24.789Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.790Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.790Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.820Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.821Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.821Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.821Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.821Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.851Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.852Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.853Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.853Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
2024-03-26T12:35:24.884Z [NITRO]::Debug: Could not kill running process on port 3928. Might be another process running on the same port? Error: timeout
etc, etc.
Until manually killing
2024-03-26T12:35:32.618Z [NITRO]::Debug: Nitro exited with code: 1
Thank you, The case of killing Nitro requested every time the context length value changed, is indeed a problem. Even when Nitro was killed successfully (see below log), can we reduce these duplicate request? @louis-jan
2024-03-26T13:10:05.460Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:05.630Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:05.687Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:05.720Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:05.785Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:05.980Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:06.044Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:06.194Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:06.299Z [NITRO]::Debug: Request to kill Nitro 2024-03-26T13:10:07.261Z [NITRO]::Debug: Nitro process is terminated 2024-03-26T13:10:07.261Z [NITRO]::Debug: Nitro process is terminated 2024-03-26T13:10:07.262Z [NITRO]::Debug: Nitro process is terminated 2024-03-26T13:10:07.262Z [NITRO]::Debug: Nitro process is terminated 2024-03-26T13:10:07.261Z [NITRO]::Debug: Nitro process is terminated
looking good on Jan v0.4.10-367 ✅