bug/feat: Windows uninstall should delete the Jan Data Folder

[0xSage]

Describe the bug A clear and concise description of what the bug is.

Steps to reproduce Steps to reproduce the behavior:

1. Windows > Add or Remove programs
2. Uninstall Jan
3. Jan Data Folder still persists after uninstallation

[Van-QA]

Additional Note:

• Currently, no folders or data are being removed when uninstalling the Jan app. Only the Jan app itself is deleted.
• This is why we have not documented any folders or data that users should expect to disappear after uninstallation.
• We will update this information once the removal process is implemented or if possible, please help us with a doc page to highlight that we are not removing any data yet, linking to this issue for reference @hieu-jan

Linking related ticket: #1435, #1654

[dan-jan]

I'm personally not sure if we should delete the Jan Data Folder if Jan is deleted. This data belongs to them, not to Jan = they may want to use the models, conversaions with different apps in the future

[0xSage]

There should be an option to. And users can check/uncheck it. Similar with their appdata/cache file.

On Fri, Mar 15, 2024 at 11:33 PM Daniel @.***> wrote:

I'm personally not sure if we should delete the Jan Data Folder if Jan is deleted. This data belongs to them, not to Jan = they may want to use the models, conversaions with different apps in the future

— Reply to this email directly, view it on GitHub https://github.com/janhq/jan/issues/2377#issuecomment-1999919237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQVWFCCU4QUCITTXHR74MQDYYMIFBAVCNFSM6AAAAABEXNR7SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZHEYTSMRTG4 . You are receiving this because you authored the thread.Message ID: @.***>

[hiento09]

PR #2705 When a user uninstalls the Jan app via the Windows Control Panel, the following notification will be displayed:

If a user changes the Jan Data folder, since this folder belongs to the user, it will not be deleted. cc @dan-jan , @0xSage , @Van-QA

[Van-QA]

If a user changes the Jan Data folder, since this folder belongs to the user, it will not be deleted.

Note that reinstallation at this stage will be a clean install, Jan app no longer connected to the existing Jan data folder (that remains from the previous step)

1. Users will have to override the data manually if needed, which is why we need a correction of the message to

Do you also want to delete the **default** Jan data folder at ... cc: @hiento09

2. Update the popup of move Jan data folder:

• Correct the msg for all OS: Are you sure you want to relocate Jan data folder to C:\Users\ptvan\Downloads\New folder? A restart will be required afterward, and the original folder will remain intact.
• Add this msg for windows only: Note that Jan will not erase the new Jan data folder during future uninstallation.

cc: @namchuai

3. And also document this on our website :pray: