jan icon indicating copy to clipboard operation
jan copied to clipboard
verified publisher icon janhq

bug: Quickask - Jan processes dangling in background after quitting on Windows

Open freelerobot opened this issue 1 year ago • 4 comments

Describe the bug A clear and concise description of what the bug is.

-v0.4.8-322

  • windows amd ryzen
  • 4070s

Steps to reproduce Steps to reproduce the behavior:

  1. Open App

  2. Click X

  3. 5 Jan processes remain running, as indicated in task manager image

  4. type cmd+j

  5. The quick ask loader animation shows for a few seconds

  6. Then nothing happens. The app doesn't open, quick ask doesn't finish loading. image

  7. Open the app from bottom nav again

  8. Try Quick Ask

  9. Broken Entirely

Why it's a problem

Jan disappears from TaskManager > Apps, so the app is theoretically not running. But the 5 dangling processes are forever running as background processes. Albeit not taking up much resources

Questions

  • Can we name processes more distinctly? So we can tell from names which one is running
  • What is the current expected behavior when users click x on windows?

freelerobot avatar Mar 14 '24 13:03 freelerobot

Currently, if we are enabling QuickAsk, we will display Jan in tray. Which means Jan still running even user clicked close on main window.

I think multiple processes shown in task manager is normal for electron app. Visual studio code has same behavior. Image

But the issue that you captured (QuickAsk display installing extension) is a bug. We troubleshoot this issue in PR #2543

I will retest, follow your steps and update.

namchuai avatar Apr 01 '24 07:04 namchuai

Ah yes, upon checking, most apps have this behavior. I've noticed this with Notion, 1Pass, Nordvpn, etc. I think having Jan persist as a process when the window is closed is OK.

Can users click a button to Quit Jan in which case we fully terminate the process?

Re bug; yes that's separate. Thanks!

On Mon, Apr 1, 2024 at 3:11 PM NamH @.***> wrote:

Currently, if we are enabling QuickAsk, we will display Jan in tray. Which means Jan still running even user clicked close on main window.

I think multiple processes shown in task manager is normal for electron app. Visual studio code has same behavior. Screenshot.2024-04-01.at.14.07.25.png (view on web) https://github.com/janhq/jan/assets/10397206/cafccc9e-8c1f-4244-a6b2-5b09bbb7a698

But the issue that you captured (QuickAsk display installing extension) is a bug. We troubleshoot this issue in PR #2543 https://github.com/janhq/jan/pull/2543

I will retest, follow your steps and update.

— Reply to this email directly, view it on GitHub https://github.com/janhq/jan/issues/2356#issuecomment-2029286529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQVWFCG37IH6V2736IAB5YTY3ECCDAVCNFSM6AAAAABEWDFX6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGI4DMNJSHE . You are receiving this because you authored the thread.Message ID: @.***>

freelerobot avatar Apr 01 '24 08:04 freelerobot

I can't reproduce this issue after the fix. @Van-QA , please help us to re-validate. Thank you 🙏

namchuai avatar Apr 03 '24 02:04 namchuai

As of now, on Windows even with Quick Ask OFF, closing Jan app (using the red X button) will not fully terminate all processes, and from that, users cannot reopen that Jan app.

Image

Jan v0.4.10-363 I will retry with Jan v0.4.10-364 and provide the result here. Updated: not facing the issue using Jan v0.4.10-364

Van-QA avatar Apr 08 '24 01:04 Van-QA