jan icon indicating copy to clipboard operation
jan copied to clipboard

feat: error when model is too big for user's device RAM

Open imtuyethan opened this issue 1 year ago • 6 comments

Problem

Though we do not know all the reasons of somethin's amiss, but we do know that if users use not enough RAM model it will show the same error, let's separate this case & write a different error message for it. Context: Screenshot_2024-01-15_at_6 23 40_PM

New copies

Figma link Oops! Model size exceeds available RAM. Consider selecting a smaller model or upgrading your RAM for smoother performance.

Screenshot 2024-01-16 at 5 33 11 PM

imtuyethan avatar Jan 16 '24 10:01 imtuyethan

Tested and looking good on Jan v0.4.4-169 ✅

image

Van-QA avatar Jan 24 '24 06:01 Van-QA

Reopen as this issue is not solved cc @Van-QA @louis-jan @urmauur

My app log: app.log

https://github.com/janhq/jan/assets/89722390/866bede9-cc8b-4a13-bc24-024d92d52b63

imtuyethan avatar Feb 02 '24 09:02 imtuyethan

@imtuyethan i think it's model failed load in your video mean while the ticket when model is too big for user's device RAM

for test this ticket you need successfully load and model with label not enough RAM cc @Van-QA @louis-jan

urmauur avatar Feb 06 '24 15:02 urmauur

Thank you for the first check @urmauur. Now is my turn for the nitro crash & error handling.

louis-jan avatar Feb 06 '24 15:02 louis-jan

Failed QA during 0.4.8, will move to ~~0.4.9~~ 0.4.10 🙏

louis-jan avatar Mar 07 '24 04:03 louis-jan

The previous fix is no longer relevant. A fix from llama.cpp (inference engine) has addressed the issue. For now, there is no way to distinguish. I will investigate further.

louis-jan avatar Mar 28 '24 05:03 louis-jan

deprecated as after Hub revamp, we will no longer allow user to download model that is too big for their RAM

imtuyethan avatar Jul 02 '24 18:07 imtuyethan