jan
jan copied to clipboard
janhq
bug: can't manually set value in Max Token input box anymore
Describe the bug
A clear and concise description of what the bug is.
Steps to reproduce Steps to reproduce the behavior:
- Go to Inference params > Max Tokens
- Try to type 2048
- It doesn't let me: it either falls to the min or max value with each keystroke
- Very frustrating, because hte input box UI suggests that I can type any value I want
cc @imtuyethan
Expected behavior I should be able to adjust the values with slider or text input box. Minimally, I should be able to type any value in Max Token.
Screenshots If applicable, add screenshots to help explain your issue.
Environment details
- Operating System: macos
- Jan Version: 0.4.3-143
This is our recent update to avoid some misleading issues, such as:
- Users can input a very large value, which breaks the app.
- Users can set the maximum value via model.json. cc @urmauur @imtuyethan
This is our recent update to avoid some misleading issues, such as:
- Users can input a very large value, which breaks the app.
- Users can set the maximum value via model.json. cc @urmauur @imtuyethan
I had a feeling. UX is confusing, feels like a bug, and we'll get more bug reports. We could disable the input action or perhaps there is a better solution @imtuyethan
Same complaint here. Can not increase Max Tokens beyond 4k.
If max tokens / cix_len can be changed in model.json file - this needs to be exposed in the UI ;)
Right now, the model goes haywire after only around 2k words:
$> wc < chat_history 203 2919 19286
Well... Maybe 3k words :D (set ctx_len to 20480 and max_tokens to the same in model.json).
Yeah this is kinda weird, i cannot clear the number @urmauur
https://github.com/janhq/jan/assets/89722390/86500ea8-a403-4d67-b21e-c3257f49c9d4
Suggestion: When users enter a number that exceed min or max number, we only revert to the min/max number + show tooltip when users leave the input field (by clicking outside, tap enter)
Yeah this is kinda weird, i cannot clear the number @urmauur
Screen.Recording.2024-01-14.at.10.54.51.PM.mov
@imtuyethan that's is minimum threshold
@urmauur @louis-jan Suggestion: When users enter a number that exceeds min or max number, we only revert to the min/max number + show the tooltip when users leave the input field (by clicking outside or tapping enter)