jan icon indicating copy to clipboard operation
jan copied to clipboard

bug: UI - Hub - Green color setting makes the download button blend with the use button, causing user confusion.

Open Van-QA opened this issue 1 year ago • 3 comments

Describe the bug The color of the download button is based on Settings > General > Appearance > Accent Color. When users choose Green as the main color for Jan App, both Download and Use button is in Green.

Steps to reproduce Steps to reproduce the behavior:

  1. Go to Settings > General > Appearance > Accent Color.
  2. Click on Green
  3. Go to Hub
  4. Observe the color of both button (Use and Download)

Expected behavior We need these two buttons in different colors for easier identification.

Screenshots image

Environment details Operating System: MacOS Jan Version: 0.4.3 Processor: Apple M2 Pro RAM: 16GB

Additional context This is how the button looks when using purple (for reference only) image

Van-QA avatar Jan 09 '24 09:01 Van-QA

On the other hand, should we make these sliders colored based on the Accent Color setting as well? (currently selecting purple) image

Van-QA avatar Jan 09 '24 09:01 Van-QA

@imtuyethan mentinoed that designs only reflect ONE color for secondary color. More of a frontend fix that needs to happen where we make all colors consistent.

freelerobot avatar Jan 12 '24 07:01 freelerobot

@urmauur looks like the main issue was fixed in the nightly build recently, can you help us with the sub issue https://github.com/janhq/jan/issues/1475#issuecomment-1882725884 as well? Many thank

Van-QA avatar Jan 12 '24 12:01 Van-QA

@urmauur, on the other hand, the current Use button when hovering makes the text look hidden from the button, can you correct this together with in this ticket as well? many thanks.

image

Van-QA avatar Jan 16 '24 07:01 Van-QA

@Van-QA Let's close this issue for now. Many components & colros are not correct and I'm aiming to create another thorough ticket on this for @urmauur. One of these things that will be included in this ticket is theme & darkmode: https://github.com/orgs/janhq/projects/5/views/26?pane=issue&itemId=48450336

imtuyethan avatar Jan 16 '24 07:01 imtuyethan