jan icon indicating copy to clipboard operation
jan copied to clipboard

feat: users can symlink model binaries

Open freelerobot opened this issue 1 year ago • 4 comments

Problem

  • Users don't want duplicated model binaries
  • Users may want various model.json configuration files for a single model

Success Criteria A clear and concise description of what you want to happen.

Questions:

  1. Should repurpose the model.json > source_url property for this? Or something else? I'm out of the loop on this.
  2. How to ensure backwards compatibility if so?
source_url: RELATIVE_PATH_TO_MODEL_BINARY
# versus
source_url: REMOTE_URL

Not in scope yet

  • Files/rag

Additional context Add any other context or screenshots about the feature request here.

  • Related: #1010

freelerobot avatar Jan 05 '24 07:01 freelerobot

I really need that

lilskippyy avatar Jan 05 '24 15:01 lilskippyy

From user: https://superuser.com/questions/1020821/how-can-i-create-a-symbolic-link-on-windows-10

freelerobot avatar Jan 08 '24 14:01 freelerobot

The PR for this ticket has been merged. Please help to verify it @Van-QA . Thank you!

namchuai avatar Jan 23 '24 02:01 namchuai

Since we support moving the Jan Data Folder, is this issue still relevant? Is the use case where we don't want to put heavy models in C:? If so, users can now freely move model files around disks by setting the Jan Data Folder. We can deprecate this one since it will complicate model.json and edge cases when users delete a symlink or original model. cc @imtuyethan @0xSage

louis-jan avatar Jan 29 '24 05:01 louis-jan

cases

model.json should always be in jan data folder, but the model binary can be anywhere.

@louis-jan we can close this issue if we end up building #1735 (but isn't it the same thing?).

freelerobot avatar Feb 14 '24 08:02 freelerobot

@0xSage I've added the impl following model.json update to unblock #1735. Users now can use absolute model url in sources.

louis-jan avatar Feb 14 '24 14:02 louis-jan

@0xSage I've added the impl following model.json update to unblock #1735. Users now can use absolute model url in sources.

Thanks thats greate, closing this issuel

freelerobot avatar Feb 15 '24 02:02 freelerobot