start working on themes

[bilelmoussaoui]

Should fix #299 #240 once it's ready This shouldn't be merged yet, more commits are coming this evening!

[bilelmoussaoui]

@jangernert Everything should work fine, except a small issue that i couldn't figure out (little tired :/) The installed themes are correctly detected on both locations global and local one, the fallback theme (saved on gresource works fine too), but the length of the static variable themes on ArticleTheme is always empty (i've added some printing on my local machine and the themes are correctly detected.. but not added to the static Variable) My Vala skills aren't that good as yours, can you take a look? Thanks! Edit: already fixed it on my local machine, i will push that to themes branch with other fixes :)

[bilelmoussaoui]

@brendanlong Thanks for the review again! I've pushed few modifications on my latest commit :)

[bilelmoussaoui]

@jangernert Can you see if everything is alright for you? :+1:

[jangernert]

Just wanted to mention the cmake files ^^ As default we should imo straight up port the current default theme and just strip out all the color variants

[bilelmoussaoui]

@jangernert I will do that :)

[jangernert]

Code seems fine and worked flawlessly for me. The only thing missing is to have the 2 themes on the same quality level as the current themes. Otherwise it will be a downgrade from a user point of view.

[bilelmoussaoui]

Yeah, lt's what i will work on those days :)