Jan
Jan
> I am happy to help review this PR. But given the activity that is already visible, I'd push this effort to a later stage. Feel free to ping me...
As commented in #1103 , please make sure the all relevant (non renaming related changes) from #1103 are moved to this PR (I think they are all in here anyways)....
let's just try to follow this convention when we do squash commits for PRs onto `main`. This will make it easier to order the commits on main. For the changelog...
Yes, this has a lot of conflicts with the changes to the shaping we made and we want this PR to be merged asap. @manuelgloeckler planned to continuing this PR....
I think this one can be closed in favor of #1151 or not @manuelgloeckler @tomMoral ?
Hi @bkmi to move on with this PR I suggest the following: As we would prefer to not do the renaming to `critic`, we should drop those changes. The PR...
Yes, something is off here with the rebasing. There are also conflicts with `main`. I will make a separate branch to check how to fix it..
ok, merging `main` into `amortizedsample` fixed the conflicts and removed all the tracked changes from the other PRs. 👍
there seems to be a failing tests during CD: ```bash pytest tests/linearGaussian_snpe_test.py::test_c2st_multi_round_snpe_on_linearGaussian[snpe_a] ```
> Main is currently failing at tests due to: > > ```shell > max_err = np.max(error) > > assert max_err < 0.0027 > E assert 0.0033298< 0.0027 > ``` >...