Jan Esser

Absolutely! Last but not least the value could go into a secret, which is ref'd like few lines above. > @janesser is this what you are thinking? [PhilipNelson5@5131b29](https://github.com/PhilipNelson5/harbor-helm/commit/5131b297fb94aff1391e66e00c411dac8620a152)

> Isn't this already possible with the current state of this branch with something like this? > > ```yaml > core: > containerEnv: > - name: CONFIG_OVERWRITE_JSON > valueFrom: >...

@PhilipNelson5 in case of oidc secrets and most other use-cases we have credentials in hand - so yeah, don't offer bad practice like having credentials in configmaps.

@PhilipNelson5 We are close ;-) If you would append a line such as ```yaml CONFIG_OVERWRITE_JSON: {{ .Values.core.configureUserSettings }} ``` to https://github.com/goharbor/harbor-helm/blob/master/templates/core/core-secret.yaml ```yaml {{- if .Values.core.configureUserSettings }} - name: CONFIG_OVERWRITE_JSON valueFrom:...

@PhilipNelson5 You have a point about b64enc. Just like you proposed, looks perfectly fine. BTW you could refresh the PR - depending on your branching, just push to https://github.com/PhilipNelson5/harbor-helm/tree/core-env-vars again.

@zyyw hope your points were covered in a best-practice fashion. any idea when you will be able to review this?

@zyyw don't forget about us here. thanks in advance.

@khmarbaise @dantran any chance this is ever merged?

@dantran as you see in #44 this PR aligns we latest maven3 api. I wonder if there is someone around using maven2. https://maven.apache.org/maven-2.x-eol.html official EOL has been 2009. Today is...

fyi i started some draft of an distributed query bus, over here: https://github.com/janesser/axon-distributed-demo/tree/master/src/main/java/org/axonframework/queryhandling the is some cartridge pattern inside, where implementation with above mentioned jgroups and spring-cloud can be plugged...