go-ipset icon indicating copy to clipboard operation
go-ipset copied to clipboard

Modified to use new case-sensitive lowercase logrus import

Open koshatul opened this issue 7 years ago • 3 comments

Sirupsen changed their github account to sirupsen, so this title-case import will have issues with projects using the new lower case import.

Updated to use the new lower-case version.

koshatul avatar Feb 09 '18 03:02 koshatul

This is great, but I'd just like to note that personally I find it preferable for libraries to return errors rather than logging, unless It simply defines a log interface and I can provide my own implementation to harmonise it with the importing app logging.

fcvarela avatar Feb 12 '18 15:02 fcvarela

I agree, but I was just getting it working first, I haven't gone back to that project again and I'm not sure this is even maintained anymore.

koshatul avatar Feb 22 '18 05:02 koshatul

Depending on the dep management tool used, this PR can indeed be pretty useful. Would like to get this in also @janeczku

bvandewalle avatar Mar 02 '18 22:03 bvandewalle