Jan Čurn

Results 80 comments of Jan Čurn

Related issue: https://github.com/apifytech/apify-js/issues/228

BTW, probably there is no point to support `format` parameter at all. Other functions like `pushData` also only work with objects, so `forEach` and `getItems` could only work with objects...

Indeed, slashes are currently not recognized. PRs welcome. On a related note, phone number detection using regular expressions is rather poor, to make it work properly, we'd need to use...

I think this is a good idea. Maybe I'd call the option differently, e.g. `maxRequestCount` to make it more clear. One note: if the new request has `forefront: true`, shall...

Actually, since the underlying storage is not read-after-write consistent, calling `addRequest` and `getRequest` immediately after that might return `null`, and thus cause weird bugs. I'm flagging this as bug then.

This might also be the cause of this problem: ``` 2019-02-14T11:59:46.283Z ERROR: BasicCrawler: handleRequestFunction failed, reclaiming failed request back to the list or queue {"url":"https://www.example.com/","retryCount":1} (error details: type=record-not-found, statusCode=404) 2019-02-14T11:59:46.286Z...

Just a note that the `RequestQueue` should support the use case where one actors writes to the queue and another one is reading from it. Perhaps the cache should be...

IMHO we can reduce the rate limiting for this API endpoint

I assume you'd like to add extra headers to the `HTTP CONNECT` method, right? Currently, this is not possible. See `HandlerTunnelChain` implementation, PRs welcome.

Hi @Benraay, so if I understand it correctly, you'd like to pass a custom header to the CONNECT request to the target proxy. It's the following line of code: https://github.com/apifytech/proxy-chain/blob/master/src/handler_tunnel_chain.js#L28...