Jan Bartel

Results 214 comments of Jan Bartel

Odd, I can see code that is checking the `ComplianceViolationListeners` set in the `HttpConfiguration` and if none are set, it is set to a default, no-op instance. I can't immediately...

@cyin869 ok, I'll close this as an issue for jetty for now.

> One idea is to re-use the `*.war` format, with no `WEB-INF/web.xml` but a `WEB-INF/jetty-web.xml`. > > We already support `WEB-INF/jetty-web.xml` for eeN deployments, so we should be able to...

I still think we shouldn't reuse a `.war` to refer to a non-servlet webapp. I don't like the presence `WEB-INF` and `web.xml` which are servlet concepts. For starters, it will...

@vmassol is this the `jetty-web.xml` file that your project uses here: https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/WEB-INF/jetty-web.xml Is it only these 2 properties that you need to configure, or is there more?

> Generally I think that `jetty-web.xml` is not a great way to configure anything.... but there are certainly use-cases like this one where it is the best option. Thus no...

> > So I would suggest we do the following for ee8/9/10 and beyond: > > > > * look for a `jetty-web-x.y.z.xml` where `x.y.z` matches the executing version (eg...

@vmassol I'm closing this issue, as I believe we fixed this in jetty-12.1.x with #11752 and #11746 and then backported that to jetty-12.0.x with #11966. So AFAIK this is resolved,...

@vmassol ahhh, I think you're going by the suggested names in this issue. When it came to implementation, we chose slightly different name pattern to match all our other naming...

@lorban any insight on this one?