Jan Barášek

Results 34 comments of Jan Barášek

I do not understand what error is.

In PR #98, the deployment of automatic tests is solved (unit test + PhpStan). At the same time, I fix a number of bugs and the tests pass.

@syteknet-core I don't want to merge your branch to mine. This increases control complexity and reduces the chance of final merging. Each feature must be added individually.

@syteknet-core I added an automatic test for PhpStan as GitHub Action and now it appears to be passed: https://github.com/janbarasek/JShrink/runs/1526425900 How can I add other mandatory tests to the CI so...

@syteknet-core Ok, I already know what the mistake was. I added an automatic GitHub unit test, which will start automatically. Everything is okay now. https://github.com/janbarasek/JShrink/runs/1526628460 ![Snímek obrazovky 2020-12-09 v 21...

@syteknet-core I think it's better to merge each branch independently, because each PR has to deal with exactly one thing.

This means that, for example, the cache can never be removed if there are many parallel requests to the application. How to safely delete the cache contents if there is...

So could Nette implement a `force` switch? There are certainly valid cases where this is useful.

The minus sign could be inserted as a user input in the administration. I think it should always be ensured that the function never returns two consecutive minus signs, even...