ssd1306 icon indicating copy to clipboard operation
ssd1306 copied to clipboard

Published 20 hours ago • verified publisher icon jamwaffles

Update to embedded-hal-1.0.0

Open irii opened this issue 1 year ago • 8 comments

Hi! Thank you for helping out with SSD1306 development! Please:

  • [x] Check that you've added documentation to any new methods
  • [x] Rebase from master if you're not already up to date
  • [x] Add or modify an example if there are changes to the public API
  • [x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • [x] Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • [ ] Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

Updated to embedded-hal 1.0.0 Updated rust-version to 1.75 for display-interface package

  • Works on an CM4 module with I2C

irii avatar Jan 15 '24 01:01 irii

P.s. CI is failing. I don't have much time to look into it right now so I'd appreciate it if you can see if you can fix the issues.

jamwaffles avatar Jan 15 '24 09:01 jamwaffles

Thanks for the information. I will have a look by time. BR

irii avatar Jan 15 '24 09:01 irii

The main reason of failing is the missing embedded-hal 1.0.0 support for stm32f1xx-hal. Maybe the examples should be migrated to stm32f4xx-hal (already has 1.0.0) or disable until an implementation is available.

irii avatar Jan 15 '24 21:01 irii

Any progress on this? I've been using my own embedded-hal v1.0.0 fork instead, however this seems a little more polished than mine. I would be happy to migrate the CI to another platform if needed!

Sycrosity avatar Apr 22 '24 13:04 Sycrosity

@Sycrosity Currently not. All examples use the stm32f1xx-hal library. This library currently has no support for embedded hal 1.0 which is the main reason for the currently paused development.

irii avatar Apr 22 '24 21:04 irii

@Sycrosity Currently not. All examples use the stm32f1xx-hal library. This library currently has no support for embedded hal 1.0 which is the main reason for the currently paused development.

If it would help, I would happily switch the examples over to something like esp-hal, which I am quite familar with writing code for.

Sycrosity avatar Apr 23 '24 22:04 Sycrosity

Any progress so far? I would also much appreciate if this PR would be merged as it also solves my issue (https://github.com/jamwaffles/ssd1306/pull/211).

ne0h avatar May 23 '24 05:05 ne0h

Currently not because of lack of time.

A workaround would be to use https://github.com/ryankurte/embedded-hal-compat which has now offical support for embedded-hal 1.0.0

BR, Ivan

irii avatar May 23 '24 13:05 irii