jamulussoftware
Landing page language reworked
Closes #841
Context: Fixes an issue? Related issues
Status of this Pull Request
What is missing until this pull request can be merged?
Does this need translation?
Checklist
- [ ] I've verified that this Pull Request follows the general code principles
- [ ] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
- [ ] I'm sure that this Pull Request goes to the correct branch
@ignotus666 Maybe, but Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated. so waiting to do that.
No. You just need to rebase NOT use a merge to resolve the conflicts. I changed the branch now.
What's the status of this PR? For some reason I can't seem to render is locally but that may be just be me.
Edit: Oh...
./wiki/en/misc/1-index.html:46: (po4a::xml)
Unexpected closing tag </> found. The main document may be wrong.
Fixed that, but jekyll still not serving it :-(
@gilgongo I don't know. This shouldn't do it one would think. Lots of conflicting files. From memory I did it because someone complained about consistency with what I was doing vis-a-vis the website, so down this "it is all terrible" rabbit-hole it went. Unfortunately, avoiding the current state doesn't trump concerns for "marketing".
I think maybe it's breaking because you've put HTML in the metadescription header in 1-index.html. Remove that and it should build. Always best to make sure it builds locally before you do a PR too - editing the website is a nightmare.
Meanwhile, this is what the body of the page looks like with that fixed. I have to say it reads rather oddly to me (very different tone of voice to the rest of the site!):
@gilgongo. Thanks. I've got the flu so I am a bit under the weather. Got some ideas for how to shorten that down. "as per the helpful guidelines." and something like "Rehersals, tutoring, performances, and even the spoken word …" And then a lineshift and some air after "Play together remotely"
... doesn't trump concerns for "marketing".
Is there a list of concerns around "marketing"?
I mean parts of this were included in the page already. Probably are still things outstanding. I'd say close it and raise issues.
@pljones Feel free to cherry-pick it into master. My itch to scratch is doing things well, and it was all uphill before getting anywhere close here. If it starts mattering at some point, let me know.
To give some idea of what I am looking at. Just for basic stuff, the header is too big because the logo takes up enough vertical space to make the whole thing scroll on resolutions people still use. Sentences aren't line-shifted. It is a wall of text without imagery at the bottom I click my language and get the language switched, but also a red box saying "This site might also be available in your native language. Select your preferred language below:"… etc, etc.