jamuluswebsite icon indicating copy to clipboard operation
jamuluswebsite copied to clipboard
verified publisher icon jamulussoftware

1049 Fix JSON header layout

Open pljones opened this issue 1 year ago • 4 comments

Short description of changes

Fix JSON header layout

Context: Fixes an issue? Related issues Fixes #1049

Status of this Pull Request Need to see the Github build output...

What is missing until this pull request can be merged? Might work, might not... let's see :)

Does this need translation? No.

Checklist

  • [x] I've verified that this Pull Request follows the general code principles
  • [x] I'm sure that this Pull Request goes to the correct branch
  • [ ] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.

pljones avatar Sep 28 '24 17:09 pljones

We could probably also merge this into release...

ann0see avatar Sep 30 '24 20:09 ann0see

How about:

  • merge anything from Weblate into next-release
  • merge this into release
  • rebase next-release to release
  • update Weblate to pick up the above

pljones avatar Oct 01 '24 09:10 pljones

Possible, but this requires a review of weblate changes.

If we merge this to release, the setup should automatically merge (not rebase) release to next release.

ann0see avatar Oct 02 '24 19:10 ann0see

OK, so

  • [x] merge anything from Weblate into next-release (because I get nervous about it getting confused if it's got outstanding changes)
  • [ ] merge this into release
  • [ ] wait for the magic to happen
  • [ ] assess any problems and fix them

pljones avatar Oct 03 '24 15:10 pljones

Let's try this.

ann0see avatar Oct 05 '24 11:10 ann0see