jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Chat window missing menu items when tabbed

Open chrisrimple opened this issue 5 years ago • 5 comments

On Mac OS (Mojave), I've enabled Tabs for applications: Apple > System Preferences > Dock > Prefer Tabs = Always. As a result, Jamulus windows appear as tabs in a single application window. That's great, except that clicking on the Chat tab hides the File, View, and Help menus. The missing menus should always be visible.

image image

chrisrimple avatar Nov 04 '20 00:11 chrisrimple

As far as I understand this new Mac OS feature (since I have an old version of Mac OS, I do not have this feature available), it simply puts the windows of an application in tabs. So the menu what you see is the same as if your application was not "tabbed" and the window is selected. So, e.g., if you do not use that new Mac OS feature, start Jamulus and have the Chat window got the focus, you should also only see the Edit menu, right?

corrados avatar Nov 07 '20 09:11 corrados

@corrados Yes, you're correct. But perhaps all the menus should be present even for the Chat window, for ease-of-use?

chrisrimple avatar Nov 07 '20 21:11 chrisrimple

The menus are window specific in Jamulus, e.g.:

Jamulus main window Edit menu: grafik

Chat window Edit menu: grafik

corrados avatar Nov 08 '20 08:11 corrados

My point is that perhaps the menus should not be window-specific. There are many multi-window applications in which all menus are always present. :)

chrisrimple avatar Nov 08 '20 17:11 chrisrimple

Hi, Sorry for the maintenance noise here. I’m just into triaging issues.

I think this issue can be resolved by some code wise re-structuring, since other apps also do that. Probably something is not implemented correctly in Jamulus?

I'm not an expert for macOS apps, but maybe some macOS dev can jump in here?

@ngocdh @emlynmac

Note: I will unsubscribe from this issue and won’t receive responses from any new comments. If you have any questions concerning maintenance, feel free to ping me.

ann0see avatar Apr 22 '22 18:04 ann0see

The current Jamulus implementation runs with each window as an independent task. To group them in tabs "feel wrong" from the Jamulus UI design because it is wrong for the Jamulus UI design.

Switching between the Chat Window and any other window on Windows, for example, is the same as switching between two separate applications - Alt-TAB. If you want to close the Chat Window, it's the same as closing an application, Alt-F4.

That design is currently intentional - "Escape" to close a subsidiary window has been deliberately prevented. However, I do think the UI design could benefit from a rethink at some point.

pljones avatar Oct 05 '22 09:10 pljones