jamulussoftware
Where available, use the commit time rather than commit id, for sort
Short description of changes
As discussed elsewhere, I'd like the --showallservers sort to use the commit time rather than commit id, where it's available. This means changing the APP_VERSION to add the git timestamp to the end and then splitting that off for display purposes. The define DISPLAY thus becomes a call to a method that does the trim.
CHANGELOG: Use the commit time rather than commit id for sort
Context: Fixes an issue?
No.
Does this change need documentation? What needs to be documented and how?
When the docs for the sort on Version are written, they'd need to take this into account.
Status of this Pull Request
Tested locally.
What is missing until this pull request can be merged?
Nothing broke -- existing servers sort exactly the same way as before as they have no timestamp.
Checklist
- [x] I've verified that this Pull Request follows the general code principles
- [x] I tested my code and it does what I want
- [x] My code follows the style guide
- [x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
- [x] I've filled all the content above
Example from build that displays version but hasn't had this update, where a server is running that has got this update:
Example from a build that displays version and has this update, for the same server (compared with the above):
Ack the review request, but I'm away this week, so won't be able to examine until next week.
https://semver.org/#spec-item-10 Actually, reading that:
- It reckons we shouldn't take any of it into account
- I should have used dot not colon
...I think....
~/Library/Cache/jamulus-dependencies/create-dmg/create-dmg/v1.2.2 ~/work/jamulus/jamulus
install -d /usr/local
install -d /usr/local/bin
install create-dmg /usr/local/bin/create-dmg
install -d /usr/local/share/create-dmg
cp -R support /usr/local/share/create-dmg
cp -R examples /usr/local/share/create-dmg
cp -R tests /usr/local/share/create-dmg
~/work/jamulus/jamulus
Creating disk image...
hdiutil: create failed - Resource busy
Error: Process completed with exit code 1.
That's a new one. I'll rerun it...
Creating disk image... hdiutil: create failed - Resource busy Error: Process completed with exit code 1.That's a new one. I'll rerun it...
I've seen that happen randomly for a long time. Rerunning usually works. Don't know why it happens.