jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Connect Dialog "Version" column - width not saved

Open pljones opened this issue 2 months ago • 3 comments

Describe the bug

For the "Server Name", "Ping Time", "Musicians" and "Location" columns in the server list of the Connect dialog, if the column width is changed, Jamulus shows the column the same width on the next run. However, the width of the "Version" column doesn't seem to get saved/restored.

To Reproduce

  1. Open the Connect dialog
  2. Widen the dialog to show the "Version" column and adjust to fit one of the "...dev-(commit)" format names
  3. Exit Jamulus
  4. Restart Jamulus
  5. Open the Connect dialog

Expected behavior

The "Version" column should still be wide enough to fit the "...dev-(commit)" format names

Screenshots

Operating system

Version of Jamulus

Jamulus 3.12.0beta3

pljones avatar Oct 01 '25 17:10 pljones

I can't see anywhere in settings.cpp or Jamulus.ini where the column widths are saved explicitly.

The only relevant thing I can see is in clientdlg.cpp where it does:

pSettings->vecWindowPosConnect  = ConnectDlg.saveGeometry();

And then settings.cpp encodes vecWindowPosConnect into winposcon_base64 for Jamulus.ini.

If saveGeometry() saves the column widths of the QTreeWidget, I don't know why it doesn't save the version column width too.

softins avatar Oct 03 '25 17:10 softins

I have just done some tests with changing the widths of other columns in the connect dialog, and have demonstrated that none of the column widths gets saved. They are not included in the window geometry.

So we would need to add a new item to store the column widths explicitly in Jamulus.ini, and to restore them on startup.

softins avatar Oct 04 '25 21:10 softins

Oh! OK, not a bug then, anyway.

pljones avatar Oct 05 '25 08:10 pljones