jamulussoftware
Add iOS Icon
Short description of changes
To be able to deploy and test the iOS app on AppStore connect, an icon is needed (https://github.com/jamulussoftware/jamulus/pull/2625#issuecomment-1131915533). I just went the easiest way and created an (ugly version of) the main icon for iOS. This may or may not work with Qt5 builds. CHANGELOG: iOS: Add icon to iOS app Context: Fixes an issue?
Not directly. However, having an icon is necessary. Does this change need documentation? What needs to be documented and how?
No Status of this Pull Request Ready for review. Need to check if the Qt5 build fails or not.
What is missing until this pull request can be merged?
Checklist
- [x] I've verified that this Pull Request follows the general code principles
- [x] I tested my code and it does what I want (Qt6 build only, Qt5 will fail or not on GitHub)
- [x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
- [x] I've filled all the content above
As screenshot.
We'd need a @jamulussoftware/designers who makes this one nice.
@softins @gilgongo could you please also have a look at this one? I'd like to get this in also for iOS support. This makes building with TestFlight easier (as AppStore connect requires an icon)
I would prefer the icon to match the other platforms. We already have src/res/io.jamulus.jamulus.png, src/res/fronticon.png and src/res/win-mainicon.ico. Putting one of those designs on a white rounded square would look better, I think. That's what "AIM Jamulus" did:
If you really need the icon with a blue square background, the white part of the image needs to move down a bit, to be vertically centred.
Thanks. It absolutely doesn't need to be how it is currently.
We should just try to follow https://developer.apple.com/design/human-interface-guidelines/app-icons
I would personally prefer to only have the flash in white without the cloud and a blue background. However, I did not succeed to get only the flash out of the image.
The icons are still not perfect, but I'd argue they better now. Also added iOS 18 dark and tinted icons. ~~I cannot test those.~~ Tested via Simulator. See below. For the standard one, I'll check later tonight.
As soon as this is merged, I'll create a new TestFlight build with the crash fix.
I don't know how to load the Unsigned IPA onto my iPad to test it.
Checkout sideloadly. It may not work with Qt5.
https://gist.github.com/ann0see/8f354ed0ff154a2e9c47359eb8043020
