jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Make about chat show up as fullscreen on iOS

Open ann0see opened this issue 1 year ago • 2 comments

Fixes an overflow bug for the about dialog on iOS.

Related to: https://github.com/jamulussoftware/jamulus/pull/3343

Short description of changes

Attempt to show chat dialog as full screen. Doesn't work yet - especially if rotating the screen.

CHANGELOG: CONDENSE WITH https://github.com/jamulussoftware/jamulus/pull/3343 Context: Fixes an issue?

Fixes: #3383

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

To be tested. Unfortunately, also the close button on the chat on iOS crashes the application. I think this was documented somewhere and is probably due to a null pointer de-reference.

What is missing until this pull request can be merged?

Not sure

Checklist

  • [x] I've verified that this Pull Request follows the general code principles
  • [ ] I tested my code and it does what I want
  • [ ] My code follows the style guide
  • [ ] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • [ ] I've filled all the content above

ann0see avatar Oct 03 '24 19:10 ann0see

BlissOS Android seems ok too.

ann0see avatar Oct 03 '24 21:10 ann0see

This doesn't seem to be enough. In general, the chat window seems very buggy on iOS with Qt6. The aspect ratio is off and tapping on close hangs he app. Not sure how to continue here.

ann0see avatar Oct 04 '24 19:10 ann0see

Do we want to leave this and see if the Qt overhaul in Jamulus 4 helps? Will #3413 help?

pljones avatar Dec 12 '24 17:12 pljones

Unfortunately it doesn't seem to work since some text boxes overlap.

ann0see avatar Dec 12 '24 20:12 ann0see

I think we'd rather close this and try out other approaches.

ann0see avatar Dec 29 '24 11:12 ann0see