jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Build process error and warning for 3.11.0rc1

Open pljones opened this issue 1 year ago • 5 comments

Describe the bug

When editing the 3.11.0rc1 release, I noticed the following error: image

Probably something in the deployment scripts.

There's also a warning relating to macOs in the output: image but may not be related.

To Reproduce

Cut a release candidate.

Expected behavior

No errors

Version of Jamulus

3.11.0rc1 release build.

pljones avatar Sep 14 '24 09:09 pljones

I don't think they are related. I believe there's something wrong in two places.

  1. Deployment upload
  2. macOS caching

ann0see avatar Sep 14 '24 16:09 ann0see

For 1, the cleanest way would be to call gh release upload in the respective scripts instead of the hacky cross platform method we use currently:

https://github.com/jamulussoftware/jamulus/blob/97388abfb6fca1f3fa156c9d22e7350cd59a3dfe/.github/workflows/autobuild.yml#L434-L436

The issue is Windows: https://github.com/cli/cli/issues/5099

Otherwise, we could just upload every file from the deploy directory with a wildcard.

For 2, further investigation is needed.

ann0see avatar Sep 14 '24 18:09 ann0see

I think for now we'll just split the release upload into two artifacts again.

https://github.com/ann0see/jamulus/releases/tag/r0_3_10_0

ann0see avatar Sep 14 '24 19:09 ann0see

Concerning 2, it seems to be comparable to https://github.com/actions/setup-node/issues/362

Maybe we need to use a non standard location to put Qt to, or just delete the cache.

ann0see avatar Sep 14 '24 19:09 ann0see

OK, as it doesn't appear to have a discernable negative effect, I'm bumping the problem to after the release.

pljones avatar Sep 16 '24 17:09 pljones

I'd put the Qt install to ~/qt. I also do this on my test machine. And it seems to work: https://github.com/ann0see/jamulus/actions/runs/16708653240/job/47290443212

ann0see avatar Aug 03 '25 19:08 ann0see