jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Add iOS case for GetOperatingSystem() function in util.h for soundness on iOS

Open ann0see opened this issue 1 year ago • 1 comments

Describe the bug https://github.com/jamulussoftware/jamulus/blob/d1dfd33447bc9377b905efc00dad1ec81a5a15c4/src/util.h#L1097 does not seem to handle iOS explicitly. (Spotted by looking through code). This function will probably return OT_MAC_OS on iOS builds (at least explorer.jamulus.io says so), since there aren't iOS servers around (yet).

To Reproduce

Compile Jamulus for iOS as server and check if it returns macOS or Linux.

Expected behavior

Should return iOS

Screenshots

N/A

Operating system

iOS

Version of Jamulus

source code from main.

Additional context

/

ann0see avatar Aug 26 '24 18:08 ann0see

Ok. Can be fixed by removing the defined ( __APPLE__ ) from the macOS case and adding a

#elif defined ( Q_OS_IOS )  
    return OT_I_OS;

case.

ann0see avatar Aug 26 '24 19:08 ann0see