jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Upgrade macOS build to macOS 14

Open ann0see opened this issue 1 year ago • 3 comments

Short description of changes

  • This will also build on arm runners
  • Switches build directory to more standard location on Apple silicon macs
  • Updates to use virtual environment for python as per https://docs.brew.sh/Python-for-Formula-Authors#python-declarations-for-applications

CHANGELOG: Upgrade main macOS build to macOS 14 and Apple Silicon build

Context: Fixes an issue?

Fixes: #3296 Does this change need documentation? What needs to be documented and how? No

Status of this Pull Request

Ready for testing

What is missing until this pull request can be merged?

Review and test

Checklist

  • [x] I've verified that this Pull Request follows the general code principles
  • [x] I tested my code and it does what I want
  • [x] My code follows the style guide
  • [x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • [x] I've filled all the content above

ann0see avatar Jun 20 '24 20:06 ann0see

Still needs testing on macOS.

ann0see avatar Jun 22 '24 20:06 ann0see

Ok. Client and server run on macOS. But https://github.com/jamulussoftware/jamulus/issues/3287 shows up and may be even worse: I cannot register to a directory on macOS at all!

ann0see avatar Jun 23 '24 19:06 ann0see

@pljones I believe this is only a minor change (even though the build architecture changed). It runs on macOS non legacy Intel as expected. The build times may decrease.

ann0see avatar Jun 30 '24 13:06 ann0see

Just wanted to add a point of interest. I just tried rebasing and running a test build of mine that runs CodeQL on the main Mac build instead of on the legacy build. It would appear that CodeQL can't be enabled on the ARM runner. At least maybe not without other changes. See https://github.com/softins/jamulus/actions/runs/9874046539

softins avatar Jul 10 '24 14:07 softins

I think it's not ARM but rather code signing. We moved codeql to legacy once in the past.

ann0see avatar Jul 10 '24 20:07 ann0see

I think it's not ARM but rather code signing. We moved codeql to legacy once in the past.

CodeQL for Mac currently is on legacy, and has been for a long time. I was just experimenting with moving it back to the main build, which worked after the sudo change to the code that builds the dmg, and prior to the change to macos-14 on ARM.

The error messages on the run I linked to above suggest that the problem is with the ARM building environment, not the signing. Something to do with Rosetta.

But it's not a big problem to leave it as it is; I just thought it was good for us to be aware of the limitation.

softins avatar Jul 10 '24 20:07 softins