jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Build: Bump lando/notarize-action from 4f5869b09386e8336802159031e4189e0919ae20 to bd2f055b8685623053d14594e9c5742c912befaf

Open dependabot[bot] opened this issue 1 year ago • 1 comments

Bumps lando/notarize-action from 4f5869b09386e8336802159031e4189e0919ae20 to bd2f055b8685623053d14594e9c5742c912befaf.

Changelog

Sourced from lando/notarize-action's changelog.

v2.0.2 - June 17, 2023

v2.0.1 - April 27, 2023

  • Added guard around unsupported tools
  • Fixed bug causing no default tool to be set

v2.0.0 - April 27, 2023

  • Added support for both altool and notarytool
  • Switched set-output and save-state to new $GITHUB_OUTPUT and $GITHUB_STATE. See this
  • Switched default tool to notarytool
  • Updated all core actions to use v3 if possible

NOTE: Originally forked from https://github.com/devbotsxyz/xcode-notarize

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Apr 08 '24 17:04 dependabot[bot]

Needs review.

ann0see avatar Apr 08 '24 17:04 ann0see

@dependabot rebase

softins avatar Jul 10 '24 14:07 softins

Needs review.

What kind of review? I've looked at the code for the action at https://github.com/lando/notarize-action/commits/main/, although I'm not familiar with the project. We can verify that our project builds correctly with this PR, but I guess the operation of notarize-action can't be tested unless we are signing a release? Does signing/notarization currently work in our repo?

I would be inclined to merge this, and investigate any problems if they occur later.

softins avatar Jul 10 '24 14:07 softins

I don't think we notarize ourselves. So I don't think we can test this.

ann0see avatar Jul 10 '24 17:07 ann0see

In my opinion it's an avoidable dependency. I'm a bit worried about a security related action we don't fully understand.

ann0see avatar Jul 10 '24 17:07 ann0see

@dependabot close

ann0see avatar Aug 22 '24 18:08 ann0see