jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Inconsistent inclusion of timestamps in logs

Open strk opened this issue 2 years ago • 3 comments

Logs of client connections include timestamp while logs of servers connections (to directory) do not. This inconsistency result in either duplication of timestamp (if you add them externally) or lack of timestamp (if you don't).

See #3001

I'd suggest making it an option to include them, or never include them (relying on external tools to timestamp them).

strk avatar Feb 04 '23 08:02 strk

Jamulus doesn't write a log of server connections to a directory.

We can remove the log of client connections to a server and have them treated the same way, though. It would simplify Jamulus.

pljones avatar Feb 04 '23 09:02 pljones

Yeah, I would simplify. I was actually surprised I couldn't run ONLY a directory w/out an associated server. If it was possible I'd have less problems with this logging inconsistency :)

strk avatar Feb 05 '23 10:02 strk

I was actually surprised I couldn't run ONLY a directory w/out an associated server.

Currently the minimum client count is validated to be more than zero and less than (IIRC) 150. I think we did take a look at making zero possible but it would need additional work to just allowing it and setting the client count to 1 does discourage use as a general use server. That's how all the built-in directories except Any Genre 1 work. (And that's because AG1 directory is the default server.)

pljones avatar Feb 06 '23 19:02 pljones