jamulus
jamulus copied to clipboard
Translations update from Hosted Weblate
Translations update from Hosted Weblate for Jamulus/Jamulus app.
It also includes following components:
Current translation status:
@ann0see I do that so I know what I am unsure about. Mostly I do it to keep track of what source strings need fixing.
@jujudusud great. It's just that it would be good to have one approver per language before it gets merged.
@ann0see If you want to review everything I have done, run it through auto-translation. The quality of the source strings isn't good enough to warrant complaining about anyone else. Removing the "needs editing" flags makes it much harder for me to change that.
@comradekingu What's so terribly wrong with the source strings? Could you give some examples? Sure some strings could possibly be made clearer, but you do seem to sound quite dismissive of them as a whole, as if they're so bad a proper translation isn't possible. You're the first translator to raise this as an obstacle for translating.
If you want to review everything I have done, run it through auto-translation.
No need for that. Usually we let the translators decide and ask for other potential reviewers if they exist to spot spelling mistakes etc. If you're not yet ok with some translations that's totally fine (the translator is mostly in charge of his/her own translation anyway). As soon as we reach release candidate stage, the existing strings should be "releasable".
What's so terribly wrong with the source strings?
I think there are some unclear strings - at least I find some once in a while. Best would be to raise an issue and list them with a suggestion + explanation what needs fixing
Review checklist:
- [ ] Translator listed in the
src/util.cpp
optionally add link to PR or code (todo: Add kingu and invite to matrix/discord) - [ ] Punctuation and spacing consistent
- [x] Signal words consistent ("ASIO", "Buffer")
- [ ] App translations: No untranslated strings (
grep unfinished -5 src/translation/translation_$TRANSLATION*.ts
) (not to be checked in this stage) - [x] App translations: Only a single
.ts
file checked in (.qm
in addition is also OK)
@ignotus666 The source strings aren't too far off, but I'd rather do something about it. This way it becomes far easier to translate Jamulus for yet others. I don't have a lot of time, but I'll have a look and see what files need changing to update the source strings correctly.
We also need to add the information for the translators in the translation.md file and in each issue created.
Plus what ever process documents adding a new translator needs to be reviewed -- ideally so we've got an issue template we can use.
Fixes #2867
I approuved all the strings. Waiting for Weblate to push the commit.
Fixes #2870
https://hosted.weblate.org/translate/jamulus/jamulus-app/en/?q=has:comment#comments Can that lot get closed?
@pljones those messages on weblate are gone now.
@hoffie yes, @comradekingu is missing in the utils.h file, as far as I know.