UI: Make checkboxes self-labelling

[pljones]

Short description of changes

UI/UX issue #2723 requests that all check boxes be made "self-labelling". This makes the change to the relevant forms.

CHANGELOG: Make checkboxes self-labelling

Context: Fixes an issue?

Fixes: #2723

Does this change need documentation? What needs to be documented and how?

Yes, User Manual and Server Manual screen shot updates are needed. This affects translations.

Status of this Pull Request

Needs review.

What is missing until this pull request can be merged?

Needs review.

Checklist

• [x] I've verified that this Pull Request follows the general code principles
• [x] I tested my code and it does what I want
• [x] My code follows the style guide
• [x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• [x] I've filled all the content above

[pljones]

Website documentation is covered in https://github.com/jamulussoftware/jamuluswebsite/issues/816

[ann0see]

This seems to change much more than just the self-labeling checkboxes and makes the My Profile tab look strange due to the misaligned dropdown boxes on macOS

[pljones]

This seems to change much more than just the self-labeling checkboxes and makes the My Profile tab look strange due to the misaligned dropdown boxes on macOS

Yes, as noted in the issue.

Is there an unrelated bug in MacOS, then?

[ann0see]

Is there an unrelated bug in MacOS, then?

As it only shows up on this PR, I do think it's related.

[pljones]

Is there an unrelated bug in MacOS, then?

As it only shows up on this PR, I do think it's related.

If it only shows on MacOS, it's unrelated.

[ann0see]

It could be a Qt6 issue then.

[ann0see]

No. It seems to be the same on the legacy build.

[pljones]

No. It seems to be the same on the legacy build.

Thanks for checking. I know we've had some Qt issues on MacOS (Qt5 and Qt6)... It's strange that Alias is different from Stadt - they're the same field type. I'll check there's nothing obviously different...

[pljones]

OK, I've now manually edited the clientsettingsbase.ui file to make the two input fields the same (copying the properties from the City/State to the Alias/Name). Can you take a look (once the artifact is there) to see if it's okay? (It looks the same in Linux.)

[ann0see]

No. Still the same

I think you should revert to the old box layout.

[pljones]

Hold on... is that just the field highlighting? Tab onto the audio alerts field and do another screenshot, could you?

[pljones]

I'm happy enough to move this to 3.10.0.

[pljones]

Just to "zoom in" on the poor alignment: MacOS vs Linux (displayed on Windows)

The MacOS fields are failing to follow the direction to fill the space given to them and align.

[ann0see]

@pljones posting as requested:

[ann0see]

Server:

[pljones]

I've also done a different version here... https://github.com/pljones/jamulus/pull/new/bugfix/%232723-self-label-checkboxes-v2

[pljones]

Based on your Qt Designer screenshots (and the behaviour I've seen in different builds locally)... all I can say is that it's highly unpredictable what the behaviour will be! Even with my version, I got a different layout on a second build... I'm sure the Qt layout engine does have some logic...

[ann0see]

I've also done a different version here...

https://github.com/pljones/jamulus/pull/new/bugfix/%232723-self-label-checkboxes-v2

Will look at this version then.

[ann0see]

that's 3.9.0dev-96c0e843-dirty (your second approach) and this seems to be ok.

[pljones]

that's 3.9.0dev-96c0e843-dirty (your second approach) and this seems to be ok.

The field edge alignment is still poor compared with Linux and Windows - but I guess that's just the MacOS styling. At least in that case they're filling the width correctly. I've just (force) pushed a more extensive set of changes to ...-v2 -- broken down into a series of commits to make it clear what changes in each.

Artifacts for this should end up here: https://github.com/pljones/jamulus/actions/runs/3078837526

(Although that branch has now been rebased, so the build is slightly out of date.)

[pljones]

OK, pljones:bugfix/#2723-self-label-checkboxes has been rebased to "latest" master as of now.

• builds: https://github.com/pljones/jamulus/actions/runs/3084620441

The "v2" version has also been rebased to master.

• builds: https://github.com/pljones/jamulus/actions/runs/3084621307

There's also now a "v3" which is the "best of both" - well, a rewrite of the .ui file. On Qt Creator 4 on Windows and Qt Creator 6 on Linux the layouts all look good. Same when running under Qt5 on either Windows or Linux. (In fact, the layout is an improvement over the current one in a number of places: the Country/Region, Audio Channels and Jitter Buffer labelling.)

• builds: https://github.com/pljones/jamulus/actions/runs/3084621939

[pljones]

Moved out to 3.10.0.

[ann0see]

Will test it in the following days (hopefully)

[pljones]

Post when you're ready and then I'll make sure there are builds for all the branches.

[ann0see]

Should be good tonight (or tomorrow evening)

[pljones]

"v1": https://github.com/pljones/jamulus/actions/runs/3300294109 "v2": https://github.com/pljones/jamulus/actions/runs/3300295047 "v3": https://github.com/pljones/jamulus/actions/runs/3300295685

[ann0see]

Ok. It seems as if only 2 is good. V1: V2: (ok) V3:

[pljones]

I do wonder why grid layout doesn't work on the Mac... It does explain why it's not in use.

[ann0see]

Maybe some Qt bug…

[pljones]

OK, found a couple of potentially relevant diffs from this version to "v2". @ann0see, once the build is clean, can you give it a try?

I'll get the v2 and v3 done again, anyway.

Edit Hm. Not sure what's happened but the source pre-v3 doesn't look like I'd remembered... v3 looks and acts as I'd expect, the earlier ones don't.